On 12/03/2012 10:34 AM, Brian Norris wrote:
This driver does not detach and remove its ata_host properly on device
removal. Add the common .remove helper.
Note: I do not know this driver well enough to ensure this is the right
thing to do. Merge this patch with caution.
Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
Cc: David Daney <david.daney@xxxxxxxxxx>
---
v2: no change (rebased along with previous patch)
drivers/ata/pata_octeon_cf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 1d61d5d..d8df93b 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -921,6 +921,7 @@ free_cf_port:
static struct platform_driver octeon_cf_driver = {
.probe = octeon_cf_probe,
+ .remove = ata_platform_remove_one,
Can you point me at the definition of ata_platform_remove_one()?
I can seem to find it. Without knowing what that does, I would be
inclined to NACK the whole thing.
How did you test the patch?
This patch is likely to be incomplete as the driver is also missing the
module_exit() things.
It might be simpler to just make the driver "bool" instead of "tristate"
in the Kconfig.
.driver = {
.name = DRV_NAME,
.owner = THIS_MODULE,
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
