On Wed, May 02, 2012 at 03:43:05PM -0400, Mark Lord wrote: > >> +static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc) > > > > Return bool? && maybe split the patch into two - the first separating > > out the logic into a function, the latter changing emedia handling? > > I think the two-liner from v2 is better. Heh, I don't know. It probably doesn't matter all that much either way. Let's let Jeff decide. ;) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
