On Mon, Apr 23, 2012 at 8:32 AM, Mark Lord <kernel@xxxxxxxxxxxx> wrote:
> On 12-04-22 04:38 AM, Tero Roponen wrote:
> ..
>> The change of numbering comes from commit 85d6725b7c0d7e3f ("libata:
>> make ata_print_id atomic") that changed lines like
>>
>> ap->print_id = ata_print_id++;
>> to
>> ap->print_id = atomic_inc_return(&ata_print_id);
>>
>> As the latter behaves like ++ata_print_id, we must initialize
>> it to zero to start the numbering from one.
>
> Darn! And here I though we'd finally end up with libata numbering
> matching the scsi host numbering (on most systems). :)
>
That would be nice. Libsas allocates a new ata_port and id on every
hotplug event. Whereas libata at least alllocates a port id at load
time and persists that until the driver unloads.
It makes the per-port libata.force= options impossible to use...
Although, it couldn't be scsi host number based, because we only get
one host number for an entire sas domain.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
