On Tuesday, April 03, 2012 7:48 AM, Rafal Prylowski wrote:
>
> Signed-off-by: Rafal Prylowski <prylowski@xxxxxxxxxxx>
> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ryan Mallon <rmallon@xxxxxxxxx>
Again, there should probably be a commit blurb here.
> ---
> arch/arm/mach-ep93xx/edb93xx.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> Index: linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-ep93xx/edb93xx.c
> +++ linux-2.6/arch/arm/mach-ep93xx/edb93xx.c
> @@ -233,6 +233,29 @@ static void __init edb93xx_register_fb(v
> }
>
>
The extra whitespace line here and below is not needed... But, it exists in
other places in this file so it's fine.
> +/*************************************************************************
> + * EDB93xx IDE
> + *************************************************************************/
> +static int __init edb93xx_has_ide(void)
> +{
> + /*
> + * Although EDB9312 and EDB9315 do have IDE capability, they have
> + * INTRQ line wired as pull-up, which makes using IDE interface
> + * problematic.
> + */
> + return machine_is_edb9312() || machine_is_edb9315 ||
> + machine_is_edb9315a();
> +}
> +
> +static void __init edb93xx_register_ide(void)
> +{
> + if (!edb93xx_has_ide())
> + return;
> +
> + ep93xx_register_ide();
> +}
> +
> +
> static void __init edb93xx_init_machine(void)
> {
> ep93xx_init_devices();
> @@ -243,6 +266,7 @@ static void __init edb93xx_init_machine(
> edb93xx_register_i2s();
> edb93xx_register_pwm();
> edb93xx_register_fb();
> + edb93xx_register_ide();
> }
Looks good. Thanks!
Acked-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
