On Monday 02 April 2012, Rafal Prylowski wrote: > I think that inheriting from .ata_bmdma_port_ops is quite reasonable. > Another option would be to inherit from .ata_sff_port_ops and implement > .qc_issue hook (like in pata_octeon_cf.c), but this way we end up > reimplementing the same things from libata-sff.c, IMHO. Also, I think > that it's not possible to write PATA driver without this SFF stuff > (at least for me - I'm not libata expert). > I reviewed code paths from all hooks used in ep93xx driver to make sure > that we use only ep93xx_pata_read/ep93xx_pata_write instead of ioread/iowrite. > Ok, thanks for the confirmation. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
