On Thu, Mar 29, 2012 at 7:14 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > > On 29-03-2012 9:06, Lin Ming wrote: > >>>> Add a new flag ATA_DFLAG_DA to indicate that device supports "Device >>>> Attention". > > >>>> Acked-by: Aaron Lu<aaron.lu@xxxxxxx> >>>> Signed-off-by: Lin Ming<ming.m.lin@xxxxxxxxx> >>> >>> [...] > > >>>> diff --git a/include/linux/ata.h b/include/linux/ata.h >>>> index 32df2b6..6ee41cc 100644 >>>> --- a/include/linux/ata.h >>>> +++ b/include/linux/ata.h >>>> @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) >>>> ((u64) (id)[(n) + 0]) ) >>>> >>>> #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) >>>> +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) > > >>> We prefix these macros with 'ata_' despite them being applied to >>> IDENTIFY >>> DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for >>> example, >>> applies only to IDENTIFY PAKCET DEVICE data. > > >> OK, will change it. > > > Also, what does the word "detech" mean in the subject? Typo! It should be "detect" > > > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
