On Thu, Mar 22, 2012 at 7:20 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 21 Mar 2012, Dan Williams wrote: > >> sd injects and synchronizes probe work on the global kernel-wide domain. >> This runs into conflict with PM that wants to perform resume actions in >> async context: > > ... > >> Provide a 'scsi_sd_probe_domain' so that async probe actions actions can >> be flushed without regard for the state of PM, and allow for the resume >> path to handle devices that have transitioned from SDEV_QUIESCE to >> SDEV_DEL prior to resume. > >> --- a/include/scsi/scsi_device.h >> +++ b/include/scsi/scsi_device.h >> @@ -393,6 +393,10 @@ static inline int scsi_autopm_get_device(struct scsi_device *d) { return 0; } >> static inline void scsi_autopm_put_device(struct scsi_device *d) {} >> #endif /* CONFIG_PM_RUNTIME */ >> >> +#if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_BLK_DEV_SD) >> +extern struct list_head scsi_sd_probe_domain; >> +#endif >> + > > This doesn't need to be provided to drivers outside the SCSI core, so > the declaration doesn't need to be in include/scsi. I'd move it to > drivers/scsi/scsi_priv.h. > > Apart from that, > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Thanks, will re-spin with the scsi_priv.h change. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html