Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/15/2012 11:57 AM, Tejun Heo wrote:
Hello,

On Tue, Feb 14, 2012 at 09:15:32PM -0800, Brian Norris wrote:
Perhaps a module param (for ahci_platform) that sets a flag in
ata_port_info? I'm not sure if/how I'm allowed to introduce new ATA
flags...

I think adding a module param directly to libahci.c should do.  Just
add it after ignore_sss and apply it to all ahci's on the host.

A module parameter is not necessarily the best/only option. ahci_platform already has infrastructure set up to deal with platform-specific quirks. An internal flag seems more appropriate to enable automatic handling of this on the specific platforms where it applies (plus the revert Tejun has already mentioned).

Nothing wrong with debugging the regression further (Brian's option #3), but in the meantime we need to be actively using the best known working state, which means making the "fix" opt-in rather than unconditional or opt-out.

	Jeff





--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux