Hi, On Fri, Oct 7, 2011 at 12:54 AM, Tejun Heo <htejun@xxxxxxxxx> wrote: > Hello, > > On Thu, Oct 06, 2011 at 07:53:46PM +0800, Ming Lei wrote: >> This flag is to stored into ata_port flags, so it is better to define a global >> flag. Otherwise, you have to select a value carefully which must not be >> defined in ata_port flags already, which way is very error-prone and not >> friendly. > > Bits 24:31 of ata_port flags are reserved for driver-specific uses. > Also, this is controller-wide not port-wide, so you can also add > piix_host_priv->flags and use it. > >> Anyway, I have not see obvious drawbacks to define a global ata_port >> flag. > > Sergei is right here. Please move it to driver specific flags. If we > end up doing this for multiple controllers, then we can move the flag > (and handling of it too) to generic code. OK, will update the patch to use local flag. thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
