Hi Fabio&Sergei: Thanks for your comments. Accepted. Would be changed later. Best Regard Richard Zhu On 22/09/2011, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > On 22-09-2011 14:14, Richard Zhu wrote: > >> Signed-off-by: Richard Zhu<richard.zhu@xxxxxxxxxx> >> --- >> arch/arm/mach-mx5/board-mx53_smd.c | 16 ++++++++++++++++ >> 1 files changed, 16 insertions(+), 0 deletions(-) > >> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c >> b/arch/arm/mach-mx5/board-mx53_smd.c >> index bc02894..9d06fbe 100644 >> --- a/arch/arm/mach-mx5/board-mx53_smd.c >> +++ b/arch/arm/mach-mx5/board-mx53_smd.c > [...] >> @@ -111,6 +112,19 @@ static const struct imxi2c_platform_data >> mx53_smd_i2c_data __initconst = { >> .bitrate = 100000, >> }; >> >> +static inline void mx53_smd_ahci_pwr_on(void) >> +{ >> + int ret; >> + >> + /* Enable SATA PWR */ >> + ret = gpio_request(MX53_SMD_SATA_PWR_EN, "ahci-sata-pwr"); >> + if (ret) { >> + printk(KERN_ERR "failed to get SATA_PWR_EN: %d\n", ret); >> + return; >> + } >> + gpio_direction_output(MX53_SMD_SATA_PWR_EN, 1); > > You can use gpio_request_one() instead of > gpio_request()/gpio_direction_*(). > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html