On Thu, Sep 22, 2011 at 7:14 AM, Richard Zhu <richard.zhu@xxxxxxxxxx> wrote: > Signed-off-by: Richard Zhu <richard.zhu@xxxxxxxxxx> > --- > arch/arm/mach-mx5/board-mx53_smd.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c > index bc02894..9d06fbe 100644 > --- a/arch/arm/mach-mx5/board-mx53_smd.c > +++ b/arch/arm/mach-mx5/board-mx53_smd.c > @@ -35,6 +35,7 @@ > #include "devices-imx53.h" > > #define SMD_FEC_PHY_RST IMX_GPIO_NR(7, 6) > +#define MX53_SMD_SATA_PWR_EN IMX_GPIO_NR(3, 3) > > static iomux_v3_cfg_t mx53_smd_pads[] = { > MX53_PAD_CSI0_DAT10__UART1_TXD_MUX, > @@ -111,6 +112,19 @@ static const struct imxi2c_platform_data mx53_smd_i2c_data __initconst = { > .bitrate = 100000, > }; > > +static inline void mx53_smd_ahci_pwr_on(void) > +{ > + int ret; > + > + /* Enable SATA PWR */ > + ret = gpio_request(MX53_SMD_SATA_PWR_EN, "ahci-sata-pwr"); Please use gpio_request_one. > + if (ret) { > + printk(KERN_ERR "failed to get SATA_PWR_EN: %d\n", ret); You can use pr_err instead. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html