On Mon, Aug 29, 2011 at 8:12 PM, Anton Vorontsov <cbouatmailru@xxxxxxxxx> wrote:
> Hello,
>
> On Mon, Aug 29, 2011 at 03:18:55PM +0800, Richard Zhu wrote:
>> On imx53 AHCI, soft reset fails with IPMS set when PMP
>> is enabled but SATA HDD/ODD is connected to SATA port,
>> do soft reset again to port 0.
>> So the 'ahci_pmp_retry_srst_ops' is required when imx53
>> ahci is present.
>>
>> Signed-off-by: Richard Zhu <richard.zhu@xxxxxxxxxx>
>> ---
> [...]
>> struct device *dev = &pdev->dev;
>> struct ahci_platform_data *pdata = dev->platform_data;
>> - struct ata_port_info pi = {
>> - .flags = AHCI_FLAG_COMMON,
>> - .pio_mask = ATA_PIO4,
>> - .udma_mask = ATA_UDMA6,
>> - .port_ops = &ahci_ops,
>> - };
>> + struct platform_device_id *id_entry = platform_get_device_id(pdev);
>> + struct ata_port_info pi = ahci_port_info[id_entry->driver_data];
>
> Why not pass port info via platform_data? It seems to be platform
> specific nowadays, so leave the default as is, but let the platforms
> pass their own port info through platform_data.
That's also a very clean way. However I have the concern that it might
end up with many duplicate entries.
>
> Thanks,
>
> --
> Anton Vorontsov
> Email: cbouatmailru@xxxxxxxxx
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
