On 8/11/2011 4:46 PM, Christoph Hellwig wrote: > On Thu, Aug 11, 2011 at 12:52:43PM -0600, Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR] wrote: >> This is the first part of the new block driver,mtip32xx, for Micron >> PCIe SSD, which contains the header file and source for pci and >> block related operations. > > There should be not split between pci/block and hardware related > functions, as there is no logical split either. Please remove that > layering and merge the files into one. Also given that the hardware > really just is AHCI with extensions please use the constants from > include/linux/ata.h and drivers/ata/ahci.h instead of redefining them. > The latter might need to be move to include/linux before merging the > driver for that, but for the next iteration a hacky relative include > might be enough. > > Also please get rid of the MTIP_USE_TASKLET, if it really is worth it > it needs to be seletable at runtime. > > I can't see any point of the CONFIG_PCI_MSI ifdefs - all the functions > called under it are properly stubbed out if it's not enabled. Thanks for the feedback. We have taken care of these. There are two follow-ups to do. 1. moving whole or part of drivers/ata/ahci.h to include/linux 2. mtip32xx support 32-bit ioctls too. For now, we have defined compat equivalent of struct ide_task_request_s locally. We need this support in hdreg.h -- Regards, Asai Thambi -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
