Hello. I'm really sorry for ignoring your previous e-mail. I'll fix it in the next patch. Thanks for reviewing my patch. Yuan-Hsin On Mon, Jun 20, 2011 at 4:15 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > On 20-06-2011 12:06, Yuan-Hsin Chen wrote: > >> From: Yuan-Hsin Chen<yhchen@xxxxxxxxxxxxxxxx> > >> ahci_sb600_softreset was in ahci.c. This function is used >> to fix soft reset failure and renames as ahci_pmp_retry_srst_softreset >> in libahci.c. > >> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >> index 71afe03..2de36b6 100644 >> --- a/drivers/ata/ahci.c >> +++ b/drivers/ata/ahci.c >> @@ -79,8 +79,6 @@ enum board_ids { >> }; >> >> static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id >> *ent); >> -static int ahci_sb600_softreset(struct ata_link *link, unsigned int >> *class, >> - unsigned long deadline); >> static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int >> *class, >> unsigned long deadline); >> static int ahci_p5wdh_hardreset(struct ata_link *link, unsigned int >> *class, >> @@ -106,8 +104,7 @@ static struct ata_port_operations ahci_p5wdh_ops = { >> >> static struct ata_port_operations ahci_sb600_ops = { >> .inherits =&ahci_ops, >> - .softreset = ahci_sb600_softreset, >> - .pmp_softreset = ahci_sb600_softreset, >> + .softreset = ahci_pmp_retry_srst_softreset, > > I have to ask you again: have you tried to compile this? > >> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c >> index d38c40f..0fd5a30 100644 >> --- a/drivers/ata/libahci.c >> +++ b/drivers/ata/libahci.c >> @@ -82,6 +82,8 @@ static void ahci_pmp_attach(struct ata_port *ap); >> static void ahci_pmp_detach(struct ata_port *ap); >> static int ahci_softreset(struct ata_link *link, unsigned int *class, >> unsigned long deadline); >> +static int ahci_pmp_retry_srst_softreset(struct ata_link *link, unsigned >> int *class, >> + unsigned long deadline); > > How come this is static if you reference it outside this module? > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html