On Sun, Apr 17, 2011 at 11:56 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Sun, 2011-04-17 at 13:45 +0300, saeed bishara wrote: >> On Sat, Apr 16, 2011 at 1:52 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: >> > Use a single mechanism to show driver version. >> > Reduces text a tiny bit too. >> > Remove uses of static int printed_version >> > Add and use ata_print_version(const struct device *, const char *ver) >> > and ata_print_version_once. >> any idea why we really need this driver version for in-kernel drivers? >> isn't the kernel version good enough? > > Some think it useful to see what module > version is linked against the kernel. 1. I looked at 3-4 drivers, and found that it didn't modified its version since at least 3 years, so it doesn't look to me that this version is maintained properly. 2. anyway, if you still think this feature is needed, then maybe you should consider making it generic one, this is not ata specific feature. saeed -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
