On Tue, 19 Apr 2011 13:50:12 +0200 Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > On Tue, Apr 19, 2011 at 12:08 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > >> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > >> Subject: [PATCH v2] pata_cmd64x: add enablebits checking > >> > >> Fixes IDE -> libata regression. > > > > And causes a regression too > > Could you be more explicit? > > Regression in this patch would mean that old driver currently doesn't > work which is not true.. The old driver fails on some of the hot plug boxes because the enable bits don't seem to be valid. See the rest of the discussion on this thread Hence the comment I made about needing to also check the parent bridge Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html