On Sat, 5 Mar 2011 09:01:58 +0100 Tejun Heo <tj@xxxxxxxxxx> wrote: > Hello, > > On Fri, Mar 04, 2011 at 10:47:56AM -0800, Kristen Carlson Accardi wrote: > > > Why not just do the following? > > > > > > scontrol &= ~(0x3 << 8); > > > > because, the IPM value is meaningless if we have no devices, > > so this is a wasted operation. > > What? You're trying to save one AND operation to a value which is > already in register in libata powersave path? That's wrong on so many > levels (it's not even a proper optimization, think about it). Just > make it easier on the eyes. debating this is even more of a waste of an operation, so I'll be glad to do this whatever way suites your taste. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
