Hi, On Tue, Feb 8, 2011 at 2:38 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > On 08-02-2011 16:25, Alan Cox wrote: > >>>>> We may need to set SITRE before programming slave_data. > >>>> Do you have a documentation cite for this or is it random fiddling with >>>> a >>>> driver you can't test ? > >>> It is good to enable SITRE register before programming it and all >>> Intel controllers > >> That sounds like someone quoting religion. Documentation cite please. > > SLC90E66 datasheet only says that SIDETIM register has no effect without > SITRE bit set. Alan, is this explanation sufficient to ACK this patch? (Thanks Sergei for digging it out.) Jeff, would it be possible to queue patches #01-15 for 2.6.39 if there are no further concerns with them (thus leaving the merging of PIIX-like drivers for later)? They got additional testing on ICH4 and they look mostly safe & straight-forward compared to #16-21. Thanks, Bartlomiej -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
