On 02/18/2011 02:44 PM, Tejun Heo wrote: >> > No. It doesn't have BMDMA. I just wanted to use existing framework and >> > routines. And i wasn't sure if just overriding qc_issue alone will be enough. >> > Should i keep it as it is or modify? > I see. Yeah, if the hardware doesn't really behave like a BMDMA > controller (and the fact that you need to override every bmdma ops is > a good indication of that), it usually is much cleaner to inherit from > sff and implement DMA part in the driver proper. There are several > drivers like that in the tree. > > >> > Why do these header > > files >>> needed? Unless the driver is gonna be put >>> > > in multiple .c files, there's no reason to separate out header files. >>> > > >> > >> > Ok. include/linux/pata_arasan_cf_data.h is surely required as it will be >> > used by platforms also. I kept register macros in a separate file to keep .c >> > clean. I will merge drivers/ata/pata_arasan_cf.h in .c, if you want me to. > Yes, please. Ok. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
