On 02/11/2011 01:09 PM, Sergei Shtylyov wrote:
>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
>> index 8db2426..b3ab2f7 100644
>> --- a/drivers/pci/quirks.c
>> +++ b/drivers/pci/quirks.c
>> @@ -554,18 +554,30 @@ static void __devinit quirk_ich4_lpc_acpi(struct
>> pci_dev *dev)
>> u32 region;
>> u8 enable;
>>
>> + /*
>> + * The check for PCIBIOS_MIN_IO is to ensure we won't create a
>> conflict
>> + * with low legacy (and fixed) ports. We don't know the decoding
>> + * priority and can't tell whether the legacy device or the one
>> created
>> + * here is really at that address. This happens on boards with
>> broken
>> + * BIOSes.
>> + */
>> +
>> pci_read_config_byte(dev, ICH_ACPI_CNTL,&enable);
>> if (enable& ICH4_ACPI_EN) {
>> pci_read_config_dword(dev, ICH_PMBASE,®ion);
>> - quirk_io_region(dev, region, 128, PCI_BRIDGE_RESOURCES,
>> - "ICH4 ACPI/GPIO/TCO");
>> + region &= PCI_BASE_ADDRESS_IO_MASK;
>
> Why don't you do the masking right in the patch #1? And is it really
> necessary if the region size is known to be 128 bytes?
The region here contains also the low flag bits. Yes, it can be a part
of 1/1. But I don't think it matters.
regards,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
