Hello.
Bartlomiej Zolnierkiewicz wrote:
On 08-02-2011 15:24, Bartlomiej Zolnierkiewicz wrote:
[...]
We may need to set SITRE before programming slave_data.
This makes pata_efar match the behavior of IDE's slc90e66 host driver
and also of libata's ata_piix one.
Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx>
[...]
diff --git a/drivers/ata/pata_efar.c b/drivers/ata/pata_efar.c
index 1e2ff7d..7f564d7 100644
--- a/drivers/ata/pata_efar.c
+++ b/drivers/ata/pata_efar.c
@@ -74,10 +74,12 @@ static void efar_set_timings(struct ata_port *ap,
struct ata_device *adev,
u8 pio, bool use_mwdma)
{
struct pci_dev *dev = to_pci_dev(ap->host->dev);
+ unsigned int is_slave = (adev->devno != 0);
What's the point of this variable? To save one pointer dereference? :-)
Make code more similar to ata_piix.c and thus easier for comparisons
through 'diff -ub'.
In reality it doesn't matter now that much as pata_efar (same for
pata_oldpiix) vanishes completely at the end of the patch series.. :-)
Yeah, I understood that. Just don't have time to review the full series yet.
Thanks,
Bartlomiej
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
