> respect some of my time spent on all this burdensome silly little > driver differences comparisons and read the whole patch set before > making comments on individual changes (which you certainly haven't > done given timing of your review mails and complexity of changes).. I was hoping you'd improved but apparently not. Any untested change is dangerous. An untested change that merges drivers together simply means you can break lots of stuff for no gain at all. If these were all PCI card devices it might make some sense but given they are all motherboard chipsets putting them into one driver merely increases memory use as well. As far as stuff like unsigned int has_sitre = (dev->vendor != 0x8086 || dev->device != 0x1230); and the even worse mess you generate with the added patch all the other PIIX code does this by flags, and if you had a HAS_SITRE (or NO_SITRE) flag in the device data it would be obvious to anyone reading stuff how it all fitted together. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
