Re: [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/10/2011 01:34 PM, Sergei Shtylyov wrote:
... in hpt_dma_blacklisted().

Signed-off-by: Sergei Shtylyov<sshtylyov@xxxxxxxxxxxxx>

---
The patch is against the recent Linus' tree plus the patches queued by
Jeff Garzik in his 'upstream-linus' branch.

Changes from the previous version:
- added the similar change for the 'pata_hpt37x' driver...

  drivers/ata/pata_hpt366.c |    6 +++---
  drivers/ata/pata_hpt37x.c |    6 +++---
  2 files changed, 6 insertions(+), 6 deletions(-)

Index: linux-2.6/drivers/ata/pata_hpt366.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_hpt366.c
+++ linux-2.6/drivers/ata/pata_hpt366.c
@@ -25,7 +25,7 @@
  #include<linux/libata.h>

  #define DRV_NAME	"pata_hpt366"
-#define DRV_VERSION	"0.6.9"
+#define DRV_VERSION	"0.6.10"

  struct hpt_clock {
  	u8	xfer_mode;
@@ -160,8 +160,8 @@ static int hpt_dma_blacklisted(const str

  	while (list[i] != NULL) {
  		if (!strcmp(list[i], model_num)) {
-			printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
-				modestr, list[i]);
+			pr_warning(DRV_NAME ": %s is not supported for %s.\n",
+				   modestr, list[i]);
  			return 1;
  		}
  		i++;
Index: linux-2.6/drivers/ata/pata_hpt37x.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_hpt37x.c
+++ linux-2.6/drivers/ata/pata_hpt37x.c
@@ -24,7 +24,7 @@
  #include<linux/libata.h>

  #define DRV_NAME	"pata_hpt37x"
-#define DRV_VERSION	"0.6.18"
+#define DRV_VERSION	"0.6.19"

  struct hpt_clock {
  	u8	xfer_speed;
@@ -229,8 +229,8 @@ static int hpt_dma_blacklisted(const str

  	while (list[i] != NULL) {
  		if (!strcmp(list[i], model_num)) {
-			printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
-				modestr, list[i]);
+			pr_warning(DRV_NAME ": %s is not supported for %s.\n",
+				   modestr, list[i]);

Even though I am applying these patches -- forward progress -- I would encourage you to consider ata_dev_printk() here, since we have the ata_device pointer available.


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux