2011/1/6 Anton Vorontsov <cbouatmailru@xxxxxxxxx>: > On Thu, Jan 06, 2011 at 02:43:08PM +0800, Lin Mac wrote: > [...] >> > It is overkill to rename the entirety of ahci_platform just for one override >> > function. >> > This sort of thing I would have expected to be added directly to >> > ahci_platform.c. >> It might be overkill for only one controller. but it is more clean and >> readable to have different SoC specific changes in separate files, >> especially when more SoCs need to make similar changes. > I think that renaming the file is not necessary. You can just > rename the module in the makefile. That is for consist end user experience. I wouldn't like to find my script not working anymore when changing to some linux version, simply because someone fix some issue on some platform I'm not using. > Personally I like the current approach more than putting > controller-specific fixups directly into ahci_platform. Best Regards, Mac Lin. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
