>>>>> "Greg" == Greg Freemyer <greg.freemyer@xxxxxxxxx> writes: Greg> In the mean time I've found the hdparm also looks at word 217 and Greg> reports SSD devices. It has apparently been doing that since Greg> v9.12 or so. (spring 2009). Yes. And the Linux kernel has had the sysfs parameter since 2.6.29 which came out around the same time. Greg> My current concern is that the logic is slowly diverging between Greg> the kernel 2.6.36 implementation and the hdparm v9.36 Greg> implementation. As Mark said: The whole point of hdparm is to talk directly to the device. There never was convergence, nor should there be. Greg> 1) The kernel routine ata_id_rotation_rate() (in ata.h) is only Greg> trusting word 217 if its ATA7 or higher. The standards bodies are glacially slow (ACS-2 still hasn't been ratified, although it's close. Again. Maybe). Consequently most device vendors "backport" features from the drafts. But obviously they can't and won't report compliance with an unfinished standard. There are plenty of SSD drives out there which claim ATA7 compliance and which support word 217. The reason we have a version check in the first place is to guard against legacy devices which have inadvertently put garbage in word 217. We have had the rotational flag in place for a couple of years and have had very few reports about devices misrepresenting themselves. So I'm not entirely convinced we need quirk handling for this. Your friendly kernel developers already made sure the rotational flag can be overridden from user space. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
