On 11-01-03 05:50 PM, Greg Freemyer wrote:
Would it be better if hdparm looked at /sys/block/sda/queue/rotational instead of just using word 217 of the identify block? The current divergence is: 1) The kernel routine ata_id_rotation_rate() (in ata.h) is only trusting word 217 if its ATA7 or higher. http://lxr.linux.no/#linux+v2.6.36/include/linux/ata.h#L799 2) There have been a couple proposed kernel patches to libata-scsi.c to quirk in a HORKAGE flag to set the rotation_rate to 1 (meaning SSD) for some known devices. I don't see those being ACKed yet, but if one ever gets in, hdparm will diverge from the kernels info since its going straight to the identify block for its info.
That's what hdparm is for. It reads only from the identify block for most of the -I output, so that we (kernel developers) can see exactly what the drive itself is reporting. This reporting is what makes it useful, rather than simply parroting whatever is already reported (or not) in /sys/ Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
