Re: [PATCH #upstream-fixes] libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 03, 2010 at 03:19:13PM +0100, Tejun Heo wrote:
> While separating out BMDMA irq handler from SFF, commit c3b28894
> (libata-sff: separate out BMDMA irq handler) incorrectly made
> __ata_sff_port_intr() consider an IRQ to be an idle one if the host
> state was transitioned to HSM_ST_ERR by ata_bmdma_port_intr().
> 
> This makes BMDMA drivers ignore IRQs reporting host bus error which
> leads to timeouts instead of triggering EH immediately.  Fix it by
> making __ata_sff_port_intr() consider the IRQ to be an idle one iff
> the state is HSM_ST_IDLE.  This is equivalent to adding HSM_ST_ERR to
> the "break"ing case but less error-prone.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Antonio Toma <antonio.toma@xxxxxxxxx>
> Cc: stable@xxxxxxxxxx

Ping.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux