Hi, Sergei
On Mon, Dec 20, 2010 at 7:19 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> On 19-12-2010 17:32, Wu Zhangjin wrote:
>
>> pata_cs5536 does work on the other platforms(e.g. Loongson, a MIPS
>> variant), so, remove the dependency of X86_32 and fix the building
>> errors under the other platforms via only reserving the X86_32 specific
>> parts for X86_32.
>
>> pata_amd also supports cs5536 IDE controller, but this one saves about
>> 33k for the compressed kernel image(vmlinuz for MIPS).
>
>> Signed-off-by: Zhang Le <r0bertz@xxxxxxxxxx>
>> Signed-off-by: Chen Jie <chenj@xxxxxxxxxx>
>> Signed-off-by: Wu Zhangjin <wuzhangjin@xxxxxxxxx>
>
> [...]
>
>> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
>> index 21ee23f..643488b 100644
>> --- a/drivers/ata/pata_cs5536.c
>> +++ b/drivers/ata/pata_cs5536.c
>> @@ -37,7 +37,17 @@
>> #include<linux/delay.h>
>> #include<linux/libata.h>
>> #include<scsi/scsi_host.h>
>> +
>> +#ifdef CONFIG_X86_32
>> #include<asm/msr.h>
>> +static int use_msr;
>> +module_param_named(msr, use_msr, int, 0644);
>> +MODULE_PARM_DESC(msr, "Force using MSR to configure IDE function
>> (Default: 0)");
>> +#else
>> +#define rdmsr(x, y, z) do { } while (0)
>> +#define wrmsr(x, y, z) do { } while (0)
>> +#define use_msr 0
>> +#endif
>>
>> #define DRV_NAME "pata_cs5536"
>> #define DRV_VERSION "0.0.7"
>
> I think you should increment the driver version too.
>
Will use 0.0.8 in the next revision of this patch.
With the version incrementation, can I get your "Acked-by:"?
Thanks & Regards,
Wu Zhangjin
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
