Hello. On 08-12-2010 2:16, Mike Snitzer wrote:
Classify severity of I/O errors for target and transport errors.
Signed-off-by: Mike Snitzer<snitzer@xxxxxxxxxx>
[...]
diff --git a/block/blk-core.c b/block/blk-core.c index 4ce953f..ab8c776 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2028,9 +2028,15 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes) if (error&& req->cmd_type == REQ_TYPE_FS&& !(req->cmd_flags& REQ_QUIET)) { - printk(KERN_ERR "end_request: I/O error, dev %s, sector %llu\n", - req->rq_disk ? req->rq_disk->disk_name : "?", - (unsigned long long)blk_rq_pos(req)); + char *error_type = "I/O"; + + if (error == -ENOLINK) + error_type = "recoverable transport"; + else if (error == -EREMOTEIO) + error_type = "critical target";
*switch* would be more natural here. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html