CCing linux-ide and Tejun. On 12/07/2010 01:43 AM, Jian Peng wrote:
Recently, while bringing up a new AHCI host controller, I found out that current AHCI driver (in 2.6.37-rc3) may violate AHCI spec in function libahci.c: ahci_start_engine(). From end of section 10.1.2 in AHCI 1.3 spec, it claims Software shall not set PxCMD.ST to '1' until it is determined that a functional device is present on the port as determined by PxTFD.STS.BSY = '0', PxTFD.STS.DRQ = '0', and PxSSTS.DET = 3h. It seems working well on most controller without this extra checking, but does cause problem in our new core. Since toggling PxCMD.SUD already initiated reset process at early time, and by the time of ahci_start_engine() got called, BSY bit may not be cleared yet, and forcing PxCMD.ST bit to 1 will cause problem for HW in this case. Since I do not know all history about AHCI driver, I really hope that AHCI driver and libata maintainer can comment on this.
Seems like a valid point to me, according to the spec. I'm guessing it just hasn't come up previously with other controllers?
-- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
