On 11/30/2010 04:38 PM, Kyle McMartin wrote: > On Tue, Nov 30, 2010 at 03:13:58PM +0100, Tejun Heo wrote: >>> Tejun, any ideas how I can debug this? >> >> Hmm... DIPM commands are failing with AC_ERR_OTHER. Other than DIPM >> not being configured and speed capped at 1.5Gbps, the machine works >> fine afterwards, right? Are you up for applying debug patches? >> > > Yup, it's chugging along happily, though I notice kernel builds are > taking a minute or two longer (but I don't bother to time them so it's > purely subjective.) > > Be happy to apply any debug patches, but I plan on replacing the drive > with a faster one at some point in the next few weeks. Can you please apply the following patch and report the resulting kernel log? You're on ahci, right? diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index ebc08d6..b1c39db 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1560,6 +1560,10 @@ static void ahci_error_intr(struct ata_port *ap, u32 irq_stat) } /* okay, let's hand over to EH */ + if (active_qc && ata_tag_internal(active_qc->tag)) + ata_dev_printk(active_qc->dev, KERN_WARNING, + "ahci: internal command failure, irq_stat=0x%x\n", + irq_stat); if (irq_stat & PORT_IRQ_FREEZE) ata_port_freeze(ap); diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 7f77c67..7cf236b 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1668,6 +1668,10 @@ unsigned ata_exec_internal_sg(struct ata_device *dev, /* perform minimal error analysis */ if (qc->flags & ATA_QCFLAG_FAILED) { + ata_dev_printk(dev, KERN_WARNING, + "internal command failure: stat=0x%x ehi_desc=\"%s\"\n", + qc->tf.command, dev->link->eh_info.desc); + if (qc->result_tf.command & (ATA_ERR | ATA_DF)) qc->err_mask |= AC_ERR_DEV; -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html