Re: [PATCH #upstream 1/3] libata: add @ap to ata_wait_register() and introduce ata_msleep()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2010 11:56 AM, Tejun Heo wrote:
Add optional @ap argument to ata_wait_register() and replace msleep()
calls with ata_msleep() which take optional @ap in addition to the
duration.  These will be used to implement EH exclusion.

This patch doesn't cause any behavior difference.

Signed-off-by: Tejun Heo<tj@xxxxxxxxxx>
---
These three patches fix the long-standing EH exclusion bug which was
reported more than three years ago and recently caused obscure
problems during parallel probing for ata_piix w/ SIDPR.

It basically implements EH big lock which guarantees that only single
EH of a host is running.  This achieves proper EH exclusion without
pervasive changes to each driver which would be fragile while not
harming parallel probing/EH too much.

Thanks.

  drivers/ata/libahci.c         |   18 +++++++++---------
  drivers/ata/libata-core.c     |   21 ++++++++++++++-------
  drivers/ata/libata-eh.c       |    2 +-
  drivers/ata/libata-sff.c      |   12 ++++++------
  drivers/ata/pata_bf54x.c      |    4 ++--
  drivers/ata/pata_samsung_cf.c |    2 +-
  drivers/ata/pata_scc.c        |    4 ++--
  drivers/ata/sata_fsl.c        |   19 ++++++++++---------
  drivers/ata/sata_inic162x.c   |    2 +-
  drivers/ata/sata_sil24.c      |   14 +++++++-------
  drivers/ata/sata_via.c        |    2 +-
  include/linux/libata.h        |    5 +++--
  12 files changed, 57 insertions(+), 48 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux