Hello,
On 08/30/2010 07:17 PM, Gwendal Grignou wrote:
> Keep track of the link on the which the current request is in progress.
> It allows support of links behind port multiplier.
>
> Not all libata-sff is PMP compliant. Code for native BMDMA controller
> does not take in accound PMP.
Can you please elaborate a bit more on what broke and how this patch
fixes the problem?
> -void ata_sff_queue_pio_task(struct ata_port *ap, unsigned long delay)
> +void ata_sff_queue_pio_task(struct ata_link *link, unsigned long delay)
> {
> + struct ata_port *ap = link->ap;
New line here, please.
> + ap->sff_pio_task_link = link;
It would also be useful to have WARN/BUG_ON() to make sure no two
links try to use pio_task at the same time. ie. Set
ap->sff_pio_task_link here and clear it with NULL when done and make
sure it's NULL before setting it.
Otherwise, looks good to me.
Thanks!
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
