On Sun, Aug 29, 2010 at 2:05 AM, Tejun Heo <tj@xxxxxxxxxx> wrote: > Hello, > > On 08/29/2010 02:31 AM, Gwendal Grignou wrote: >> Re-introduce port_task_data to hold the link on the which the current >> request is in progress. It allows support of links behind port multiplier. >> >> Not all libata-sff is PMP compliant. Code for native BMDMA controller >> does not take in accound PMP. >> >> Tested on Marvell 7042 and Sil7526. > > So sata_mv is using SFF state machine for PMP devices too. Didn't see > that coming. Thanks for fixing this. Can you please consider the > followings? > > * Make ata_sff_queue_pio_task() take a @qc (or @link if @qc can't be > used for whatever reason) and @delay, instead of taking @ap, @link > and @delay. Done. I keep link, because qc could be reused if the command timeout while the task is delayed. > > * Change ata_port->port_task_data to something more specific. ie. > sff_pio_task_qc or sff_pio_task_link. Done. path is next. > > Thanks. > > -- > tejun > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
