On Mon, 2010-08-23 at 10:22 +0200, Tejun Heo wrote: > On 08/20/2010 03:40 AM, Mark Lord wrote: > > Fix DSM/TRIM commands in sata_mv (v2). > > These need to be issued using old-school "BM DMA", > > rather than via the EDMA host queue. > > > > Since the chips don't have proper BM DMA status, > > we need to be more careful with setting the ATA_DMA_INTR bit, > > since DSM/TRIM often has a long delay between "DMA complete" > > and "command complete". > > > > GEN_I chips don't have BM DMA, so no TRIM for them. > > > > Signed-off-by: Mark Lord <mlord@xxxxxxxxx> .. > Don't we need this for other BMDMA commands too? If so, maybe it's > better to make it two patches? TRIM is the first/only command which actually breaks without this. It is possible that other commands may benefit as well on some DVD-RW drives, but I have not encountered those yet. So for now, I've left it as a single patch, with all of the (small) pieces together for TRIM. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
