Alan Cox wrote:
Does it really need to merge the DMA timings too? If the device can't do certain timing, it's PIO configuration should reflect that so merging PIO part only should be enough for PIO configuration, no?
The timing code knows about DMA/PIO constraints itself. The whole mucking around passing both timings is just bogus.
Pass pair->dma_mode only and it'll work out the PIO for you. Not that it matters - no real hardware has a DMA mode with a slower address setup than its PIO mode.
The address setup timing means *exactly nothing* for DMA modes. I keep wondering why it has been added to the libata timing table...
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
