Re: [PATCH RFC] ata: Intel IDE-R support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +static int is_intel_ider(struct pci_dev *dev)
> > +{
> > +	/* For Intel IDE the value at 0xF8 is only zero on IDE-R
> > +	   interfaces */
> 
>     Preferred style for multi-line comments is:

This driver uses the style I have throughout.

> > @@ -134,6 +173,10 @@ static int ata_generic_init_one(struct pci_dev
> > *dev, const struct pci_device_id if ((id->driver_data &
> > ATA_GEN_CLASS_MATCH) && all_generic_ide == 0) return -ENODEV;
> >  
> > +	if (id->driver_data && ATA_GEN_INTEL_IDER)
> 
>     I think you mean & here, rather than &&...

Oh yes most definitely, that would have unfortunate consequences.

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux