On Tue, Aug 3, 2010 at 11:49 AM, Jim Paris <jim@xxxxxxxx> wrote: > Randy Dunlap wrote: >> On Mon, 2 Aug 2010 15:07:11 -0700 Mark Knecht wrote: >> >> > On Thu, Jul 22, 2010 at 5:39 AM, Tejun Heo <tj@xxxxxxxxxx> wrote: >> > >> > Hi Tejun, >> > I'm finally home and trying to get back to this. I'm really a bad >> > programmer so I don't know what I've done wrong but it seems patch >> > isn't happy with me. >> > >> > c2stable linux # patch --dry-run -p1 <../ata_piix-sidpr-lock.patch >> > patching file drivers/ata/ata_piix.c >> > patch: **** malformed patch at line 13: >> >> Whenever the patch file was saved on this system, line 13 of it was >> split (probably by an email client). Whenever I see this, I just >> join (merge) that line and the next one and try again... sometimes >> several lines are malformed and have to be fixed like this. > > Tejun asked Mark to add a printk, and Mark added it directly to the > patch. Mark, just apply the original patch as-is, and then add the > printk to the source code in ata_piix.c. You should add it somewhere > like the piix_init_one function, e.g. right before the "Save IOCFG" > comment around line 1575. > > -jim Thanks Jim. I'll give it a shot. Cheers, Mark -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html