Hello, Bartlomiej. On 05/15/2010 08:48 PM, Bartlomiej Zolnierkiewicz wrote: > This seems to rely on an optimistic assumption that command execution > will always be successful and that no errors on disk or host level can > ever happen.. > > [ The assumption in question was introduced in the previous patch: ... > originally if the command execution failed the 'capacity' would be 0 ] Hmm... nothing really changes by this tho. Whether unlocking succeeds or not, the block layer will revalidate the disk and the state at that point will be taken as the configuration to use. There really is nothing much else to do. You try unlocking, if it unlocks, use new capacity. If unlocking fails, revalidation will report the limited size and block layer will have to use that. If the device dies due to the unlocking attempt, well, the device is dead all the same. > It also seems that the original code could be improved a lot to handle > (very unlikely but not impossible) error situations better.. If retry is deemed necessary, it's best handled inside the per-driver unlock handler. I don't think pushing EH logic upto block layer in this case would be a good idea. Block layer is basically telling the driver "do whatever you can do to unlock the native capacity, when you're done, I'll restart from the beginning". Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
