On 06/04/10 09:29 PM, Tejun Heo wrote:
..
- /* check the ending block number */
- return ((block + n_block)< ((u64)1<< 28))&& (n_block<= 256);
+ /* check the ending block number: must be LESS THAN 0x0fffffff */
+ return ((block + n_block)< (u64)((1<< 28) - 1))&& (n_block<= 256);
But why move the type casting? The cast isn't required to begin with
but starting with u64 constant means the whole compile time
calculation will be in u64 (the intention of that cast I guess).
..
The cast was there already, so I left it there.
Just moved it to cover the entire compile-time expression as a unit,
rather than just the (u64)1 as the existing code did it.
If you prefer a different format for that line, then chirp up! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
