On 03/31/2010 03:20 PM, Herbert Xu wrote: > ide: Must hold queue lock when requeueing > > ide-atapi requeues requests without holding the queue lock. > This patch fixes it by using the new ide_requeue_request function. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c > index eb2181a..12e9d7c 100644 > --- a/drivers/ide/ide-atapi.c > +++ b/drivers/ide/ide-atapi.c > @@ -263,8 +263,8 @@ void ide_retry_pc(ide_drive_t *drive) > * of it. The failed command will be retried after sense data > * is acquired. > */ > - blk_requeue_request(failed_rq->q, failed_rq); > drive->hwif->rq = NULL; > + ide_requeue_request(drive, failed_rq); Nice catch but I think it would be better to call ide_requeue_and_plug() instead of adding ide_requeue_request(). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
