Hello, On 03/29/2010 05:01 AM, Robert Hancock wrote: >> ata2.00: ATAPI: Pioneer CD-ROM ATAPI Model DR-A24X 0102, E1.02, max >> MWDMA2 >> ata2.00: NOSETXFER but PATA detected - can't skip SETXFER, might >> malfunction > > Yeah, NOSETXFER doesn't take effect on PATA drives. It could, but it > would assume that the BIOS has set the right mode which seems rather > dangerous. Well, we can issue the command, ignore the error and then check the correct mode is configured during revalidation. For now, the following should show us whether something like that would work. diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 4a28420..ca4a50a 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3446,6 +3446,10 @@ static int ata_dev_set_mode(struct ata_device *dev) "NOSETXFER but PATA detected - can't " "skip SETXFER, might malfunction\n"); err_mask = ata_dev_set_xfermode(dev); + if (err_mask) + ata_dev_printk(dev, KERN_WARNING, "SETXFER failed w/ %x\n", + err_mask); + err_mask = 0; } if (err_mask & ~AC_ERR_DEV) -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
