Re: [PATCH 2/2] libata: disable preemption during PIO copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Mar 2010 12:01:24 +0100
Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx> wrote:

> * FUJITA Tomonori | 2010-03-23 18:49:04 [+0900]:
> 
> >On Sun, 21 Mar 2010 22:53:08 +0100
> >Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx> wrote:
> >
> >> If the request has been made in user context it could be moved to a
> >> different CPU on a SMP machine between the copy and cache flush. Thus we
> >> could flush the dcache on the wrong CPU.
> >
> >This issue should be addressed in flush_dcache_page() inside?
> 
> How so? You have to remain on the same CPU on which you started the copy
> process. Once you get to flush_dcache_page() you may have allready
> switched the CPU.

Oops, I thought that you trying to address on the deferred
flush_dcache_page() issue. I don't know enough about how this pio code
works, but if your description is correct, then the patch is fine, I
guess.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux