On 03/17/2010 06:58 PM, Tejun Heo wrote:
Hello,
On 03/18/2010 02:44 AM, Jeff Garzik wrote:
It actually makes merging a lot more difficult, considering that libahci
-- which includes large amounts of ahci code movement -- was committed
to #upstream a week before this patch was posted.
Because of libahci changes, I think patch #2 (this patch) and patch #3
are more appropriate for #upstream.
The "(pdev->vendor != PCI_VENDOR_ID_NVIDIA)" may be overly broad, but
it's not wrong for 2.6.34, IMO.
Hmmm... the actual fix is in #3. I'll prep separate patches for
upstream and upstream-fixes.
What does it fix, specifically? AFAICS, the patch changes the AHCI
state from
no FPDMA AA for all NVIDIA
to
some FPDMA AA for NVIDIA
thus the current state of the code is not broken and in need of fixing,
but merely overly conservative. Am I missing something?
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
