On Tue, Mar 02, 2010 at 10:41:04PM +0300, Sergei Shtylyov wrote: [...] > >+static int __devinit ahci_probe(struct platform_device *pdev) > > Does it make sense to make this driver hotplug capable? Probably not, at least for now. Will correct. [...] > >+ WARN_ON(ATA_MAX_QUEUE > AHCI_MAX_CMDS); > > Hm... That was copied from the PCI driver. > >+ ahci_set_em_messages(hpriv, &pi); > >+ > >+ > > Extra newline? Yeah, that's all directly copied from the PCI driver. Will correct. [...] > >+ res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > Could also use platform_get_irq()... OK. > >diff --git a/drivers/ata/ahci_platform.h b/drivers/ata/ahci_platform.h > >new file mode 100644 > >index 0000000..f7dd576 > >--- /dev/null > >+++ b/drivers/ata/ahci_platform.h > > I doubt that it's good place for declaring the platform data which > will be used by the platform code. This file should be somewhere in > include/linux/, don't you think? Will change. Thanks! -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
