From: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx> Date: Sun, 28 Feb 2010 16:35:41 +0100 > the pio callbacks are called with different kind of buffers. It could be > a straight kernel addr, kernel stack or a kmaped highmem page. > Some of this break the virt_to_page() assumptions. > This patch moves the dcache flush from architecture code into generic > ide code. ide_pio_bytes() is the only place where user pages might be > written as far as I can see. > The dcache flush is avoided in two cases: > - data which is written to the device (i.e. they are comming from the > userland) This needs a flush on sparc, otherwise an alias now exists in the kernel side copy of the buffer. The D-cache flush is intentionally unconditional for PIO mode. I definitely don't want to take the same risks you guys seem to be willing to take for this optimization which is of questionable value. I also, intrinsically, really don't like these changes. For one thing, you're optimizing PIO mode. Secondly, IDE is in deep maintainence mode, if you want to optimize cache flushing do it in the ATA layer. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
