On Thursday 18 February 2010 10:44:48 pm Alan Cox wrote: > On Thu, 18 Feb 2010 19:59:22 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > Subject: [PATCH] libata: pass host flags into __ata_pci_sff_init_one() helper > > > > This was orginally proposed by Alan Cox but as a change > > for ata_pci_sff_init_one() helper function instead of > > __ata_pci_sff_init_one() one which casues needless churn > > to all host drivers and accidentally breakes few host > > drivers which are still on their way upstream. > > > > Allows parallel scan and the like to be set without > > having to stop using the existing full helper functions. > > NAK - __ is for internal symbol names. A NAK for an atang specific patch? :) - Please read DISCLAIMER in the first mail (it is there for a valid reasons). - The patch is for atang tree and said __ change happened _months_ ago as a part of (very much related) ->init_host work which is not 'upstream'. - __ has been also used for exactly such purpose in the kernel, i.e.: $ grep EXPORT_SYMBOL drivers/pci/*c|grep __ drivers/pci/htirq.c:EXPORT_SYMBOL(__ht_create_irq); drivers/pci/pci.c:EXPORT_SYMBOL_GPL(__pci_complete_power_transition); drivers/pci/pci.c:EXPORT_SYMBOL_GPL(__pci_reset_function); drivers/pci/pci-driver.c:EXPORT_SYMBOL(__pci_register_driver); Just see commit 863b18f introducing __pci_register_driver (please notice that the change was suggested by Al Viro!).. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
