On Wed, 03 Feb 2010 23:59:47 -0500 Mark Lord <kernel@xxxxxxxxxxxx> wrote: > Joe Perches wrote: > > On Wed, 2010-02-03 at 12:21 -0500, Mark Lord wrote: > >> Joe Perches wrote: > >>> String constants that are continued on subsequent lines with \ > >>> are not good. > > [] > >>> - dev_warn(ap->dev, "Failed to compute ATA timing %d, \ > >>> - set PIO_0 timing\n", ret); > >>> + dev_warn(ap->dev, "Failed to compute ATA timing %d, set PIO_0 timing\n", > >>> + ret); > >> NAK. Just stick the ret); part onto the same line and be done with it. > > > > :resend that I mistakenly sent only to Mark, with a couple more comments > > > > I disagree. > > > > Look at the long line wrapping style of the rest of the file > > and most of the kernel source. No additional arguments to > > functions are generally used after column 80. > > > > If it's ever agreed that all lines > 80 cols are OK or > > new args after column 80 are OK, then sure. Until then, > > if you want it, you should do it. > .. > > You are the code nanny trying to get this patch in. Not me. > It's a runtime bug. Are "code nannies" supposed to "try" to fix runtime bugs in libata while others just sit there and insult them? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
