On 01/14/2010 07:20 PM, Sergei Shtylyov wrote: >> + qc = ata_qc_from_tag(ap, ap->link.active_tag); >> + if (qc && (!(qc->tf.flags & ATA_TFLAG_POLLING))) >> > > () not needed around !x. Eh... I don't know. I personally prefer using minimum number of parantheses but quite a few people dislike not using them when && & || | are mixed. In the end, I don't think it really matters. It's like debating about how far the second part of a broken line should be indented. Many people strong opinions but in the end it doesn't really matter. Anyhow, if it bothers you enough to write an email about it, I'll be happy to oblige. :-) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
