Re: [PATCH] pata_hpt3x2n: fix timing register masks (take 2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> - the driver doesn't serialize access to the channels depending on the current
>   clock mode like the vendor drivers, so the clock turnaround is only executed
>   "optionally", not always as it should be;

The vendor driver I have uses that algorithm. I think I prefer your
approach however !

> - the wrong ports are written to when hpt3x2n_set_clock() is called for the
>   secondary channel;

Ouch.

> - hpt3x2n_set_clock() can inadvertently enable the disabled channels when
>   resetting the channel state machines.

Yep.

> Could you give this a bit of testing? I don't have HPT371N at hand, and it's
> seated in the board with 66 MHz PCI anyway...

I'm not likely to have a chance to do so until next year.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux